New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace usage of env variables with application config in app state #178

Merged

roman-romanov-o merged 10 commits into development from feat/move-deployments-from-env-to-config

Dec 2, 2024

Collaborator

roman-romanov-o commented Nov 26, 2024

The current approach of using env variables makes testing much harder, since variables are in global scope.

Replace it with app_config object, that's passed during application init, and could be modified for testing purposes


          Replace usage of env variables with application config in app state

63c39af

roman-romanov-o requested a review from adubovik as a code owner

November 26, 2024 11:40

Collaborator Author

roman-romanov-o commented Nov 26, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-178.nightly-test.deltixhub.io
E2E tests status: success

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app_config.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/image_tokenizer.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app_config.py Outdated Show resolved Hide resolved

roman-romanov-o added 5 commits

November 27, 2024 10:30


          Big refactoring, address comments in PR

6fd770e


          Refactor

10aba8c


          One more refactor - move exception handlers to distinct file

cd1b3df


          Make app.py even cleaner

e16cef9


          Turn off telemetry for test app instance

0b08f36

Collaborator Author

roman-romanov-o commented Nov 27, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-178.nightly-test.deltixhub.io
E2E tests status: success

adubovik reviewed

View reviewed changes

aidial_adapter_openai/routers/chat_completion.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/routers/embeddings.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/routers/__init__.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app_config.py Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app.py Outdated Show resolved Hide resolved

adubovik reviewed

View reviewed changes

aidial_adapter_openai/utils/image_tokenizer.py Outdated Show resolved Hide resolved

roman-romanov-o added 2 commits

November 28, 2024 17:47


          More refactoring due to PR comments

66faf72


          Fix: handle completions endpoint

44320f2

Collaborator Author

roman-romanov-o commented Nov 29, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-178.nightly-test.deltixhub.io
E2E tests status: success

adubovik reviewed

View reviewed changes

aidial_adapter_openai/app_config.py Outdated Show resolved Hide resolved

roman-romanov-o added 2 commits

November 29, 2024 17:14


          minor fix

cbeda2b


          Fix linter

5686a8c

adubovik approved these changes

View reviewed changes

Collaborator Author

roman-romanov-o commented Dec 2, 2024 •

edited by ai-dial-actions

Loading

/deploy-review

Environment URL: https://chat-ai-dial-adapter-openai-pr-178.nightly-test.deltixhub.io
E2E tests status: success

roman-romanov-o merged commit 33f02be into development

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet